Polyester

Polyester doesn't follow KDE's contrast settings. I think it'd be better if it did.

Re: Contrast not oka

by mart on: Mar 11 2006

Score 50%

mart
Plasma
Home

uhm, strange: both the surfaces rendering code and the code thar renders the button contours computes the colors based on the contrast value, what graphic element is not affected by the contrast value?

Re: Re: Contrast not oka

by logixoul on: Mar 11 2006

Score 50%

The glossy gradients used for the buttons, comboboxes, etc.

Re: Re: Re: Contrast

by mart on: Mar 12 2006

Score 50%

mart
Plasma
Home

here they works, i think the only thing is that this setting for some reasons affects only apps started after the contranst has been applyed and not the old ones.

Re: Re: Re: Re: Contrast

by logixoul on: Mar 12 2006

Score 50%

Okay, you're right. Thanks.

Bug

by logixoul on: Mar 11 2006

Score 50%

Regarding the "Colored left part of horizontal sliders and bottom part of vertical sliders" feature:
The coloring extends about 1cm to the right of the slider. Dragging the slider to the left extends the bad part. Dragging it to the right shrinks it. Releasing it resets it to the usual 1cm.

Testcase: "Font Size" groupbox in "Fonts" section in "Configure Konqueror".

Re: Bug

by mart on: Mar 12 2006

Score 50%

mart
Plasma
Home

uhm, yeah i noticed that. the problem is that it seems the property QSlider->value() has the value the slider had -before- the indicator was moved, i still hadn't found a way to resolve it :-(.

Re: Re: Bug

by yogeshm02 on: Mar 17 2006

Score 50%

Oops, looks like you are wrong here. You are not corerctly hadling the case where slider->minValue() could be -ve. I've modified polyester.cpp as per folowing (which solves the problem): -

(output of diff against modified polyester.cpp)
1393c1393
< double coloredWidth = ((double)r.width()/(slider->maxValue()-slider->minValue())(slider->value() + slider->minValue());
---
> double coloredWidth = ((double)r.width()/slider->maxValue())slider->value();
1400c1400
< double coloredHeight = ((double)r.height()/slider->maxValue()-slider->minValue())(slider->value() + slider->minValue());
---
> double coloredHeight = ((double)r.height()/slider->maxValue())slider->value();

Re: Re: Re: Bug

by mart on: Mar 18 2006

Score 50%

mart
Plasma
Home

oh, thank you man :-)

Re: Re: Re: Bug

by mart on: Mar 18 2006

Score 50%

mart
Plasma
Home

uhm, yeah, it has gotten better, but the colored area movement still seems not syncronized (it's still drawn correctly only after the mouse button is released)

Re: Re: Re: Re: Bug

by yogeshm02 on: Mar 20 2006

Score 50%

Explanation: slider->valueChanged() signal is emitted only when slider->tracking == TRUE; and it appears that many programmes have this set to FALSE, hence the slider is not updated while mouse button is pressed.

I have three rough ideas to achieve desired result; will reply soon if results are good. (Hint: Never looked into a KStyle code before)

Re: Re: Re: Re: Re: Bug

by yogeshm02 on: Mar 25 2006

Score 50%

I've fixed this.

(Please note that I've used version 0.8.5)

Here is the output of 'diff polyester.h polyester_my.h
---------------------------
270a271
> void sliderThumbMoved(int);
393a395
> QMap sliderValues;

Here is the output of 'diff polyester.cpp polyester_my.cpp
--------------------------------
344a345,350
> QSlider slider = ::qt_cast(widget);
> if(slider)
> {
> connect(slider, SIGNAL(sliderMoved(int)), this, SLOT(sliderThumbMoved(int)));
> connect(slider, SIGNAL(valueChanged(int)), this, SLOT(sliderThumbMoved(int)));
> }
384a391,393
> const QSlider slider = ::qt_cast(widget);
> if(slider && sliderValues.contains(slider))
> sliderValues.remove(slider);
1390c1399,1401
<
---
> int value = slider->value();
> if(sliderValues.contains(slider))
> value = sliderValues[slider];
1393c1404
< double coloredWidth = ((double)r.width()/slider->maxValue())slider->value();
---
> double coloredWidth = ((double)r.width()/(slider->maxValue()-slider->minValue()))(value-slider->minValue());
1400c1411
< double coloredHeight = ((double)r.height()/slider->maxValue())slider->value();
---
> double coloredHeight = ((double)r.height()/(slider->maxValue()-slider->minValue()))(value-slider->minValue());
4070a4082,4090
>
> void PolyesterStyle::sliderThumbMoved(int val)
> {
> QSlider *slider = ::qt_cast(sender());
> if(slider) {
> sliderValues.insert(slider, val);
> slider->repaint(false);
> }
> }

You may note that it is not only tracking == FALSE which is the cause of concern. Some sliders with tracking == TRUE also does not repaint correctly (could not found any reason), and to my surprise my own app has this behaviour!

But everything seems fine after above changes. Please test it.

Re: Re: Re: Re: Re:

by mart on: Mar 25 2006

Score 50%

mart
Plasma
Home

oh, thanks dude!
now it is much better :-)

the only very strange thing I noted is that some sliders are drawn correctly with the size computed as
coloredWidth = ((double)r.width()/slider->maxValue()-slider->minValue())(slider->value() + slider->minValue());

some others only with

coloredWidth = ((double)r.width()/slider->maxValue())(slider->value() + slider->minValue());

for example in the "panels" control center module there are both types of sliders
i should investigate why

Re: Re: Re: Re: Re:

by mart on: Mar 25 2006

Score 50%

mart
Plasma
Home

ok, fixed.
the correct formula was:
coloredWidth = ((double)r.width()/(slider->maxValue()-slider->minValue()))*(slider->value() - slider->minValue());
(and so for the height)

and thanks again for your help :-)

Re: Re: Re: Re: Re: Re: Bug

by yogeshm02 on: Mar 26 2006

Score 50%

This is the first time I've fixed something in an app of somebody else as my own app take most of my time.
But it was your style which inspired me to contribute (and also that the fix was going to be relatively easy). So, keep on the GOOD work.

Awesome Job!

by sangaho on: Mar 12 2006

Score 50%

sangaho

I love this style! And I really like how much you can customize it. My favourite button style is "flat"; it's so clean and.. simple ;)

Favourite

by powerpenguin on: Mar 15 2006

Score 50%

powerpenguin

this is like my favourite theme for KDE, they should (maybe) make it the default theme.

excelent job man.

-sol-

Gentoo Ebuild 64bit

by mattdev121 on: Mar 19 2006

Score 50%

mattdev121
Home

Hey, just mentioning that the ebuild works properly on a Gentoo AMD64 system. You just have to update the ebuild so "amd64" is one of the keywords (right next to x86).

BTW, this was tested on an intel EM64T processor. Compiled cleanly and runs fine.

Re: Gentoo Ebuild

by mart on: Mar 20 2006

Score 50%

mart
Plasma
Home

ok, i'll do that
if i understood correctly i should change the line
KEYWORDS="x86"
into
KEYWORDS="x86 amd64"
correct me if i am wrong, i'm not very expert about Gentoo.

Re: Re: Gentoo Ebuild

by franzf on: Mar 23 2006

Score 50%

franzf
Home

Yes, thats it ;)

And thx for the nice theme :)